apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...
Date Thu, 31 Dec 2015 06:32:55 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48647943
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -907,6 +912,51 @@ else if (field.getType() == float.class || field.getType() == Float.class
||
             getValue(OperatorContext.METRICS_DIMENSIONS_SCHEME));
         }
     
    +    /**
    +     * Copy attribute from source attributeMap to destination attributeMap.
    +     *
    +     * @param dest  destination attribute map.
    +     * @param source source attribute map.
    +     */
    +    private void copyAttributes(AttributeMap dest, AttributeMap source)
    --- End diff --
    
    AttributeMap does not have pullAll method. Do you want me to add this in AttributeMap?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message