apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-276 made METRICS_TRANSP...
Date Wed, 30 Dec 2015 18:45:51 GMT
Github user tweise commented on a diff in the pull request:

    --- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
    @@ -335,10 +335,16 @@
         Attribute<String> APPLICATION_DATA_LINK = new Attribute<String>(new String2String());
          * Transport to push the stats and the metrics, "builtin:{topic}" if STRAM should
push the data directly
    -     * using websocket with the given topic
    +     * using websocket with the given topic.
    +     * If using a custom transport, please use Object2String codec to specify the transport
object.  The object must
    +     * be from a class that implements the AutoMetric.Transport interface
         Attribute<String> METRICS_TRANSPORT = new Attribute<String>(new String2String());
    +     * The interval in milliseconds to resend metrics schema. Default value is 10,000
(10 seconds)
    +     */
    +    Attribute<Long> METRICS_SCHEMA_RESEND_INTERVAL = new Attribute<Long>(10000L);
    --- End diff --
    Shouldn't the resend interval be part of the transport as the need to do that is driven
by the properties of the transport, i.e. need to resend if messages could be lost?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message