apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...
Date Tue, 29 Dec 2015 20:51:51 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48568829
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -719,6 +719,11 @@ public void resetStreamPersistanceOnSinkRemoval(InputPortMeta sinkBeingRemoved)
             removeOperator(persistOpMeta.getOperator());
           }
         }
    +
    +    private void copyFrom(StreamMeta meta)
    +    {
    +      this.locality = meta.getLocality();
    --- End diff --
    
    This is used at only one place and it has only one statement, so why another function
call? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message