apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinmaykolhatkar <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1958: Exposing some field...
Date Tue, 29 Dec 2015 10:10:26 GMT
Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/149#discussion_r48531567
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractReconciler.java ---
    @@ -73,9 +73,9 @@ public void process(INPUT input)
       // this stores the mapping from the window to the list of enqueued tuples
       private Map<Long, List<QUEUETUPLE>> currentWindowTuples = Maps.newConcurrentMap();
       private Queue<Long> currentWindows = Queues.newLinkedBlockingQueue();
    -  private Queue<QUEUETUPLE> committedTuples = Queues.newLinkedBlockingQueue();
    --- End diff --
    
    Any reason why these are required to be protected?
    
    I believe these fields are very important ones for correct functioning of Reconciler along
with correct checkpointing.
    By making these protected, we're exposing the overall functionality of of this class to
get compromised.
    
    In my opinion, we need a strong case for making this protected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message