apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-272 copy operator and p...
Date Mon, 28 Dec 2015 17:15:38 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/191#discussion_r48492262
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1359,7 +1409,8 @@ private void addDAGToCurrentDAG(ModuleMeta moduleMeta)
         String name;
         for (OperatorMeta operatorMeta : subDag.getAllOperators()) {
           name = subDAGName + MODULE_NAMESPACE_SEPARATOR + operatorMeta.getName();
    -      this.addOperator(name, operatorMeta.getOperator());
    +      Operator op = this.addOperator(name, operatorMeta.getOperator());
    --- End diff --
    
    Can LogicalPlan class provide a new method that allows to add Operator with existing OperatorMeta?
Something like 
    ```
      private <T extends Operator> T addOperator(final String name, final T operator,
final OperatorMeta meta)
      {
        
      }
    ```  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message