apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shubham-pathak22 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Thu, 24 Dec 2015 06:33:52 GMT
Github user shubham-pathak22 commented on a diff in the pull request:

    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -47,10 +47,19 @@
      * @since 3.2.0
    -public abstract class Parser<INPUT> extends BaseOperator implements Converter<INPUT,
    -    ActivationListener<Context>
    +public abstract class Parser<INPUT> extends BaseOperator implements Converter<INPUT,
       protected transient Class<?> clazz;
    +  @AutoMetric
    +  protected long errorTupleCount;
    +  @AutoMetric
    +  protected long emittedObjectCount;
    +  @AutoMetric
    +  protected long rollingPercentValidTuples;
    +  @AutoMetric
    +  protected long rollingPercentErrorTuples;
    +  @AutoMetric
    +  protected long incomingTuplesCount;
       @OutputPortFieldAnnotation(schemaRequired = true)
    --- End diff --
    @ishark @chandnisingh Yes, you are correct. I tested it again. No need to remove the annotation

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message