apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ishark <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Wed, 23 Dec 2015 21:40:24 GMT
Github user ishark commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48381493
  
    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -61,25 +70,48 @@ public void setup(PortContext context)
         }
       };
     
    -  @OutputPortFieldAnnotation(optional = true)
       public transient DefaultOutputPort<INPUT> err = new DefaultOutputPort<INPUT>();
    --- End diff --
    
    Would it be good to have default as  emitting same input to error port and logging error.
    If transformation is needed, like you suggested, users can add/override additional port
for processedError or connect another operator for error processing to the default error port,
whichever applies to specific scenario. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message