apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Wed, 23 Dec 2015 21:11:09 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48379752
  
    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -61,25 +70,48 @@ public void setup(PortContext context)
         }
       };
     
    -  @OutputPortFieldAnnotation(optional = true)
       public transient DefaultOutputPort<INPUT> err = new DefaultOutputPort<INPUT>();
    -
    +  public transient DefaultOutputPort<INPUT> validatedOutput = new DefaultOutputPort<INPUT>();
       public transient DefaultInputPort<INPUT> in = new DefaultInputPort<INPUT>()
       {
         @Override
         public void process(INPUT inputTuple)
         {
    -      Object tuple = convert(inputTuple);
    -      if (tuple == null && err.isConnected()) {
    -        err.emit(inputTuple);
    -        return;
    -      }
    -      if (out.isConnected()) {
    -        out.emit(tuple);
    -      }
    +      incomingTuplesCount++;
    +      processTuple(inputTuple);
         }
       };
     
    +  public void processTuple(INPUT inputTuple)
    +  {
    +    Object tuple = convert(inputTuple);
    +    if (tuple == null && err.isConnected()) {
    +      errorTupleCount++;
    +      err.emit(inputTuple);
    +      return;
    +    }
    +    if (out.isConnected()) {
    +      emittedObjectCount++;
    +      out.emit(tuple);
    +    }
    +  }
    +
    +  @Override
    +  public void beginWindow(long windowId)
    +  {
    +    errorTupleCount = 0;
    +    emittedObjectCount = 0;
    +    rollingPercentValidTuples = 0;
    +    rollingPercentErrorTuples = 0;
    +  }
    +
    +  @Override
    +  public void endWindow()
    +  {
    --- End diff --
    
    AppDataTracker does first, last as well. Application developer can provide the dimension
scheme for the %metrics to be just FIRST/LAST


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message