apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Wed, 23 Dec 2015 21:03:34 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48379303
  
    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -61,25 +70,48 @@ public void setup(PortContext context)
         }
       };
     
    -  @OutputPortFieldAnnotation(optional = true)
       public transient DefaultOutputPort<INPUT> err = new DefaultOutputPort<INPUT>();
    --- End diff --
    
    Why don't we remove the error port and add process error tuples method which by default
logs error messages. I think logging is the obvious default behavior.
    
    Users can add error port and  override this processErrorTuples().  The reason is that
we don't know what kind of tuples are error tuples - same type as Input tuples or different.
 
    From the customer use cases seen so far they are either input tuples which are logged
to files or the type is completely different.
    Currently we don't have a reason to assume that error tuples are KeyValPair so that shouldn't
be picked as default.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message