apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shubham-pathak22 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Wed, 23 Dec 2015 04:36:18 GMT
Github user shubham-pathak22 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48321356
  
    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -61,25 +70,48 @@ public void setup(PortContext context)
         }
       };
     
    -  @OutputPortFieldAnnotation(optional = true)
       public transient DefaultOutputPort<INPUT> err = new DefaultOutputPort<INPUT>();
    --- End diff --
    
    Certainly, logs can contain stack trace. But a short error message on error port along
with error tuple would be useful for users to quickly find out validation errors by connecting
to the error port instead of digging into the logs.
    What i suggest, the port should at least have provision to send error message.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message