apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shubham-pathak22 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: Added XSD validation to XML pa...
Date Sun, 20 Dec 2015 14:21:13 GMT
Github user shubham-pathak22 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/137#discussion_r48103837
  
    --- Diff: library/src/main/java/com/datatorrent/lib/parser/Parser.java ---
    @@ -47,10 +47,19 @@
      * @since 3.2.0
      */
     @InterfaceStability.Evolving
    -public abstract class Parser<INPUT> extends BaseOperator implements Converter<INPUT,
Object>,
    -    ActivationListener<Context>
    +public abstract class Parser<INPUT> extends BaseOperator implements Converter<INPUT,
Object>
     {
       protected transient Class<?> clazz;
    +  @AutoMetric
    +  protected long errorTupleCount;
    +  @AutoMetric
    +  protected long emittedObjectCount;
    +  @AutoMetric
    +  protected long rollingPercentValidTuples;
    +  @AutoMetric
    +  protected long rollingPercentErrorTuples;
    +  @AutoMetric
    +  protected long incomingTuplesCount;
     
       @OutputPortFieldAnnotation(schemaRequired = true)
    --- End diff --
    
    schemaRequired=true is very restrictive. Suppose XMLParser  operator is used  and i don't
want pojos and so i will not connect to this port. But because of schemaRequired=true  application
will fail during verification.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message