apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-60 Iteration support in...
Date Wed, 16 Dec 2015 14:46:42 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/185#discussion_r47783467
  
    --- Diff: common/src/main/java/com/datatorrent/common/util/SimpleDelayOperator.java ---
    @@ -0,0 +1,59 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.common.util;
    +
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.Operator;
    +
    +/**
    + * SimpleDelayOperator. This is an implementation of the DelayOperator that has one input
port and one output
    + * port, and does a simple pass-through from the input port to the output port.  Subclass
of this operator can
    + * override this behavior by overriding processTuple(T tuple).
    + *
    + * Since the firstWindow method does not do anything, using this operator as-is means
data loss during recovery.  In
    + * order to achieve zero data loss during recovery, implementations must persist relevant
tuples before the recovery
    + * checkpoint for emitting during the first window after recovery.
    + *
    + * Note that the engine will automatically does a +1 on the output window ID since it
is a DelayOperator.
    --- End diff --
    
    Should `engine will automatically does` be rephrased to `engine automatically does` or
`engine will automatically do`? 
    @amberarrow: any thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message