apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-60 Iteration support in...
Date Wed, 16 Dec 2015 01:20:12 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/185#discussion_r47725499
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1613,6 +1636,37 @@ else if (stack.contains(successor)) {
         }
       }
     
    +  public void findInvalidDelays(OperatorMeta om, List<List<String>> invalidDelays)
    +  {
    +    stack.push(om);
    +
    +    // depth first successors traversal
    +    boolean isDelayOperator = om.getOperator() instanceof Operator.DelayOperator;
    +    if (isDelayOperator) {
    +      if (om.getValue(OperatorContext.APPLICATION_WINDOW_COUNT) != 1) {
    +        LOG.warn("detected DelayOperator having APPLICATION_WINDOW_COUNT not equal to
1");
    --- End diff --
    
    My understanding is that the APPLICATION_WINDOW_COUNT of delay operator should be independent
of the downstream. Can you shed some lights on this since you have implemented sliding window
and probably have better understanding than me in terms of windowing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message