apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1943 #resolve #comment co...
Date Tue, 15 Dec 2015 00:19:09 GMT
Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/129#discussion_r47580479
  
    --- Diff: library/src/main/java/com/datatorrent/lib/dimensions/aggregator/Aggregator.java
---
    @@ -0,0 +1,14 @@
    +package com.datatorrent.lib.dimensions.aggregator;
    +
    +import com.datatorrent.lib.dimensions.AggregateEvent;
    +
    +import gnu.trove.strategy.HashingStrategy;
    +
    +public interface Aggregator<EVENT, AGGREGATE extends AggregateEvent> extends HashingStrategy<EVENT>
    --- End diff --
    
    +1 This is a rare case where I agree with nesting the interface. An Aggregator will never
be used without an AggregateEvent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message