apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve
Date Thu, 10 Dec 2015 05:12:51 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/121#discussion_r47189655
  
    --- Diff: library/src/test/java/org/apache/hadoop/io/file/tfile/DTFileTest.java ---
    @@ -70,7 +73,7 @@ public void setUp() throws IOException
     
         conf.setInt("tfile.fs.input.buffer.size", tconf.fsInputBufferSize);
         conf.setInt("tfile.fs.output.buffer.size", tconf.fsOutputBufferSize);
    -    path = new Path("tmp/dtfile");
    +    path = new Path(ROOT, "/tmp/dtfile");
    --- End diff --
    
    @chandnisingh other tests in tfile using same pattern. I used the same path for consistency.
This code was copied from apache tfile implementation. Do you want all tests to use target
directory for test data?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message