apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Tue, 08 Dec 2015 22:17:54 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r47022794
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/StramWebServices.java ---
    @@ -767,8 +900,17 @@ public JSONObject getPhysicalOperatorProperties(@PathParam("operatorId")
int ope
       @Produces(MediaType.APPLICATION_JSON)
       public JSONObject getLogicalPlan() throws JSONException, IOException
       {
    -    LogicalPlan lp = dagManager.getLogicalPlan();
    -    return new JSONObject(objectMapper.writeValueAsString(LogicalPlanSerializer.convertToMap(lp)));
    +    return new JSONObject(objectMapper.writeValueAsString(LogicalPlanSerializer.convertToMap(
    +        dagManager.getLogicalPlan(), false)));
    +  }
    +
    +  @GET
    +  @Path(PATH_LOGICAL_PLAN + "/flatten")
    +  @Produces(MediaType.APPLICATION_JSON)
    +  public JSONObject getLogicalPlanFlatten() throws JSONException, IOException
    +  {
    +    return new JSONObject(objectMapper.writeValueAsString(LogicalPlanSerializer.convertToMap(
    +        dagManager.getLogicalPlan(), true)));
       }
    --- End diff --
    
    again, flatten should not be part of the resource path.  is there support for getting
individual operator/module that is arbitrarily deep under specific modules?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message