apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Tue, 08 Dec 2015 06:17:36 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46918500
  
    --- Diff: api/src/main/java/com/datatorrent/api/Module.java ---
    @@ -21,8 +21,136 @@
     import org.apache.hadoop.classification.InterfaceStability;
     import org.apache.hadoop.conf.Configuration;
     
    +import com.datatorrent.api.Context.PortContext;
    +import com.datatorrent.api.Operator.InputPort;
    +import com.datatorrent.api.Operator.OutputPort;
    +import com.datatorrent.api.Operator.Unifier;
    +
    +/**
    + * A Module is a component which can be added to the DAG similar to the operator,
    + * using addModule API. The module should implement populateDAG method, which
    + * will be called by the platform, and DAG populated by the module will be
    + * replaced in place of the module.
    + *
    + */
     @InterfaceStability.Evolving
     public interface Module
     {
       void populateDAG(DAG dag, Configuration conf);
    +
    --- End diff --
    
    My only question is how would module developer even know what application properties to
look for? Different application developer may have different way specifying application properties.
I would suggest not to pass conf object unless we there is well defined usecase..
    
    @tweise : Any suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message