apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Mon, 07 Dec 2015 09:32:21 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46800536
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
    @@ -2405,6 +2540,46 @@ private LogicalOperatorInfo fillLogicalOperatorInfo(OperatorMeta
operator)
         return loi;
       }
     
    +  private LogicalModuleInfo fillLogicalModuleInfo(ModuleMeta module, boolean flatten,
String parentModuleName)
    +  {
    +    LogicalModuleInfo lmi = new LogicalModuleInfo();
    +    lmi.name = module.getName();
    +    lmi.className = module.getModule().getClass().getName();
    +    if (flatten) {
    +      for (OperatorMeta operatorMeta : getLogicalPlan().getAllOperators()) {
    --- End diff --
    
    Yes you are correct.
    
    In the top level dag,
    operator O1 in module M1 has the name "M1:O1" with module name "M1"
    operator O2 with name "M1:M2:O2" and module name "M1:M2" 
    
    In dag of M1
    operator O1 with name "O1" with module name as null
    operator O2 with name "M2:O2" with module name "M2"
    
    When we are iterating dag M1 we need to find out the operatorMeta in the top level DAG.
I have refactored this code to remove iteration on top level DAG.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message