apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1720 Implemented Inmemory...
Date Fri, 04 Dec 2015 19:38:35 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/113#discussion_r46722810
  
    --- Diff: library/src/main/java/com/datatorrent/lib/join/AbstractJoinOperator.java ---
    @@ -0,0 +1,349 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.join;
    +
    +import java.util.ArrayList;
    +import java.util.Calendar;
    +import java.util.List;
    +
    +import javax.validation.constraints.NotNull;
    +import javax.validation.constraints.Size;
    +
    +import org.apache.hadoop.classification.InterfaceStability.Evolving;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.api.annotation.InputPortFieldAnnotation;
    +import com.datatorrent.common.util.BaseOperator;
    +
    +/**
    + * <p>
    + * This is the base implementation of join operator. Operator receives tuples from two
streams,
    + * applies the join operation based on constraint and emit the joined value.
    + * Subclasses should provide implementation to createOutputTuple,copyValue, getKeyValue,
getTime methods.
    + *
    + * <b>Properties:</b><br>
    + * <b>expiryTime</b>: Expiry time for stored tuples<br>
    + * <b>includeFieldStr</b>: List of comma separated fields to be added to
the output tuple.
    + *                         Ex: Field1,Field2;Field3,Field4<br>
    + * <b>keyFields</b>: List of comma separated key field for both the streams.
Ex: Field1,Field2<br>
    + * <b>timeFields</b>: List of comma separated time field for both the streams.
Ex: Field1,Field2<br>
    + * <b>bucketSpanInMillis</b>: Span of each bucket in milliseconds.<br>
    + * <b>strategy</b>: Type of join operation. Default type is inner join<br>
    + * <br>
    + *
    + * <b> Example: </b> <br>
    + *  Left input port receives customer details and right input port receives Order details.
    + *  Schema for the Customer be in the form of
    + *  Schema for the Order be in the form of
    + *  Now, Join the tuples of Customer and Order streams where Customer.ID = Order.CID
and the constraint is
    + *  matched tuples must have timestamp within 5 minutes.
    + *  Here, key Fields = ID, CID and Time Fields = RTime, OTime, expiryTime = 5 minutes
</b> <br>
    + *
    + *
    + * @displayName Abstract Join Operator
    + * @tags join
    + */
    +@Evolving
    +public abstract class AbstractJoinOperator<T> extends BaseOperator implements Operator.CheckpointListener
    +{
    +  public final transient DefaultOutputPort<List<T>> outputPort = new DefaultOutputPort<>();
    +
    +  @Size(min = 2, max = 2)
    +  protected transient String[] timeFields;
    --- End diff --
    
    @chaithu14 
    I think it is better to have a class, let's say,  StoreContext that encompasses  { timeField,
keyField, includeFields, Store } .
    Then you can have 2 fields leftStoreContext and rightStoreContext. It makes the code more
intuitive and easy to understand.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message