apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Fri, 04 Dec 2015 11:52:44 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46674504
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
    @@ -2405,6 +2540,46 @@ private LogicalOperatorInfo fillLogicalOperatorInfo(OperatorMeta
operator)
         return loi;
       }
     
    +  private LogicalModuleInfo fillLogicalModuleInfo(ModuleMeta module, boolean flatten,
String parentModuleName)
    +  {
    +    LogicalModuleInfo lmi = new LogicalModuleInfo();
    +    lmi.name = module.getName();
    +    lmi.className = module.getModule().getClass().getName();
    +    if (flatten) {
    +      for (OperatorMeta operatorMeta : getLogicalPlan().getAllOperators()) {
    --- End diff --
    
    module.getDag().getAllOperator() will return the operatorMeta for the operator which are
populated by this module also it will contains operatorMeta populated by the inner modules.
The operatorMeta reference is not shared between inner module and outer module. when inner
module DAG is merged with the outmodue dag, outer module dag create a new operatorMeta also
sets it moduleName from where this operator was added. The Operator object reference are shared.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message