apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1892 Convert comments to ...
Date Fri, 04 Dec 2015 07:47:26 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/117#discussion_r46656451
  
    --- Diff: demos/wordcount/src/main/java/com/datatorrent/demos/wordcount/FileWordCount.java
---
    @@ -62,33 +60,58 @@
       private static final Logger LOG = LoggerFactory.getLogger(FileWordCount.class);
       private static final String GLOBAL = "global";
     
    -  // If topN > 0, only data for the topN most frequent words is output; if topN ==
0, the
    -  // entire frequency map is output
    -  //
    +  /**
    +   * If {@literal topN > 0}, only data for the topN most frequent words is output;
if topN == 0, the
    +   * entire frequency map is output
    +   */
       protected int topN;
     
    -  // set to true when we get an EOF control tuple
    +  /**
    +   * set to true when an EOF control tuple for the current input file is received; reset
to false
    --- End diff --
    
    Should "s" of set be uppercaps? If Yes then same issue across java docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message