apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Thu, 03 Dec 2015 06:27:25 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46516514
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1079,16 +1109,179 @@ public int hashCode()
         return operator;
       }
     
    -  @Override
    -  public <T extends Module> T addModule(String name, Class<T> moduleClass)
    +  public final class ModuleMeta implements DAG.ModuleMeta, Serializable
       {
    -    throw new UnsupportedOperationException("Modules are not supported");
    +    private final LinkedHashMap<InputPortMeta, StreamMeta> inputStreams = new LinkedHashMap<InputPortMeta,
StreamMeta>();
    +    private final LinkedHashMap<OutputPortMeta, StreamMeta> outputStreams = new
LinkedHashMap<OutputPortMeta, StreamMeta>();
    +    private final Attribute.AttributeMap attributes;
    +    @SuppressWarnings("unused")
    +    private final int id;
    +    @NotNull
    +    private String name;
    +    private transient Integer nindex; // for cycle detection
    +    private transient Integer lowlink; // for cycle detection
    --- End diff --
    
    Don't see these values used anywhere..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message