apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Thu, 03 Dec 2015 04:48:09 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r46512547
  
    --- Diff: api/src/main/java/com/datatorrent/api/DAG.java ---
    @@ -164,6 +164,8 @@
       {
         String getName();
     
    +    Module getModule();
    +
    --- End diff --
    
    Not related to this PR. Does it make sense to have getMeta for ports at module level?
Can they not be derived from operator Meta? I don't see them used any where as well. Concrete
class LogicalPlan.ModuleMeta also return null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message