Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: tweise <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-148-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-148-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEX-103: Add module and
 dag int...
Content-Type: text/plain
Message-Id: <20151123071605.28587DFFDA@git1-us-west.apache.org>
Date: Mon, 23 Nov 2015 07:16:05 +0000 (UTC)

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r45576400
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
    @@ -2246,6 +2306,41 @@ public LogicalOperatorInfo getLogicalOperatorInfo(String operatorName)
         return fillLogicalOperatorInfo(operatorMeta);
       }
     
    +  public LogicalModuleInfo getLogicalModuleInfo(String moduleName, boolean flatten, LogicalPlan dag)
    +  {
    +    ModuleMeta moduleMeta = getModuleMeta(moduleName);
    +    if (moduleMeta == null) {
    +      return null;
    +    }
    +    LogicalModuleInfo logicalModuleInfo = fillLogicalModuleInfo(moduleMeta, flatten);
    +    if (flatten) {
    +      for (ModuleMeta meta : moduleMeta.getDag().getAllModules()) {
    +        if (meta.getParentModuleName() != null && meta.getParentModuleName().equals(moduleName)) {
    +          logicalModuleInfo.modules.add(getLogicalModuleInfo(fillLogicalModuleInfo(meta, flatten).name, flatten,
    +              moduleMeta.getDag()));
    +        }
    +      }
    +    }
    +    return logicalModuleInfo;
    +  }
    +
    +  public ModuleMeta getModuleMeta(String moduleName)
    +  {
    +    return getModuleMeta(moduleName, getLogicalPlan());
    +  }
    +
    +  private ModuleMeta getModuleMeta(String moduleName, LogicalPlan dag)
    --- End diff --
    
    This logic looks suspect. And why the separate private method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---