Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-163-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-163-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: - APEX-256 Added unit
 tests to v...
Content-Type: text/plain
Message-Id: <20151119075859.AD8BCE00AC@git1-us-west.apache.org>
Date: Thu, 19 Nov 2015 07:58:59 +0000 (UTC)

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/163#discussion_r45310744
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/engine/GenericNodeTest.java ---
    @@ -38,10 +49,40 @@
      */
     public class GenericNodeTest
     {
    -  public static class GenericOperator implements Operator
    +  @Rule
    +  public FSTestWatcher testMeta = new FSTestWatcher();
    +
    +  public static class FSTestWatcher extends TestWatcher
    +  {
    +    public org.junit.runner.Description desc;
    +
    +    public String getDir()
    +    {
    --- End diff --
    
    This method gets called twice for a test. Instead have a directory variable defined and initialize that variable with "target/" + desc.getClassName() + "/" + desc.getMethodName() in starting(). You don't need to store description variable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---