Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: vrozov <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-171-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-171-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEX-268 #resolve
Content-Type: text/plain
Message-Id: <20151117154157.4F881DFF87@git1-us-west.apache.org>
Date: Tue, 17 Nov 2015 15:41:57 +0000 (UTC)

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/171#discussion_r45075022
  
    --- Diff: common/src/main/java/com/datatorrent/common/util/PubSubWebSocketClient.java ---
    @@ -175,11 +181,11 @@ public void openConnection(long timeoutMillis) throws IOException, ExecutionExce
           try {
             json.put("userName", userName);
             json.put("password", password);
    -      }
    -      catch (JSONException ex) {
    +      } catch (JSONException ex) {
             throw new RuntimeException(ex);
           }
    -      Response response = client.preparePost(loginUrl).setHeader("Content-Type", "application/json").setBody(json.toString()).execute().get();
    +      Response response = client.preparePost(loginUrl).setHeader("Content-Type", "application/json")
    +          .setBody(json.toString()).execute().get();
    --- End diff --
    
    Consider introducing local variable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---