Return-Path: 
 <dev-return-1981-apmail-apex-dev-archive=apex.apache.org@apex.incubator.apache.org>
X-Original-To: apmail-apex-dev-archive@minotaur.apache.org
Delivered-To: apmail-apex-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4CC0D182AB
	for <apmail-apex-dev-archive@minotaur.apache.org>;
 Mon, 16 Nov 2015 16:16:41 +0000 (UTC)
Received: (qmail 13546 invoked by uid 500); 16 Nov 2015 16:16:41 -0000
Delivered-To: apmail-apex-dev-archive@apex.apache.org
Received: (qmail 13485 invoked by uid 500); 16 Nov 2015 16:16:41 -0000
Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.incubator.apache.org>
List-Post: <mailto:dev@apex.incubator.apache.org>
List-Id: <dev.apex.incubator.apache.org>
Reply-To: dev@apex.incubator.apache.org
Delivered-To: mailing list dev@apex.incubator.apache.org
Received: (qmail 13474 invoked by uid 99); 16 Nov 2015 16:16:40 -0000
Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2015 16:16:40 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id 8A61CC05B6
	for <dev@apex.apache.org>; Mon, 16 Nov 2015 16:16:40 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id S4MEB6alR4WC for <dev@apex.apache.org>;
	Mon, 16 Nov 2015 16:16:32 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 1C1C820C41
	for <dev@apex.incubator.apache.org>; Mon, 16 Nov 2015 16:16:32 +0000 (UTC)
Received: (qmail 11138 invoked by uid 99); 16 Nov 2015 16:16:31 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2015 16:16:31 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AD62FE050C; Mon, 16 Nov 2015 16:16:31 +0000 (UTC)
From: gauravgopi123 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-162-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-162-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: Introduce Abstract and
 Forwardin...
Content-Type: text/plain
Message-Id: <20151116161631.AD62FE050C@git1-us-west.apache.org>
Date: Mon, 16 Nov 2015 16:16:31 +0000 (UTC)

Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/162#discussion_r44943593
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java ---
    @@ -23,20 +23,26 @@
      *
      * @since 0.3.2
      */
    -public interface Reservoir
    +public interface Reservoir<T>
     {
       /**
        * the count of elements in this SweepableReservoir.
        *
        * @return the count
        */
    -  public int size();
    +  int size(final boolean dataTupleAware);
    --- End diff --
    
    I agree.. I was just giving documentation of the parameter as it was me who has added this check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---