Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: tweise <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-51-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-51-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: MLHR-1812 Add anti-join
 operat...
Content-Type: text/plain
Message-Id: <20151113230928.273D5E05E1@git1-us-west.apache.org>
Date: Fri, 13 Nov 2015 23:09:28 +0000 (UTC)

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/51#discussion_r44845177
  
    --- Diff: library/src/main/java/com/datatorrent/lib/join/AntiJoinOperator.java ---
    @@ -0,0 +1,209 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.join;
    +
    +import com.datatorrent.api.Context.OperatorContext;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.api.annotation.OperatorAnnotation;
    +import com.datatorrent.lib.streamquery.condition.Condition;
    +import com.datatorrent.lib.streamquery.index.Index;
    +
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +import org.apache.hadoop.classification.InterfaceStability;
    +import org.apache.hadoop.classification.InterfaceStability.Evolving;
    +
    +/**
    + * An implementation of Operator that reads table row data from two table data input ports. <br>
    + * <p>
    + * Operator anti-joins row on given condition and selected names, emits
    + * anti-joined result at output port.
    + * <br>
    + * <b>StateFull : Yes,</b> Operator aggregates input over application window. <br>
    + * <b>Partitions : No, </b> will yield wrong result(s). <br>
    + * <br>
    + * <b>Ports : </b> <br>
    + * <b> inport1 : </b> Input port for table 1, expects HashMap&lt;String, Object&gt; <br>
    + * <b> inport2 : </b> Input port for table 2, expects HashMap&lt;String, Object&gt; <br>
    + * <b> outport : </b> Output anti-joined row port, emits HashMap&lt;String, ArrayList&lt;Object&gt;&gt; <br>
    + * <br>
    + * <b> Properties : </b>
    + * <b> joinCondition : </b> Join condition for table rows. <br>
    + * <b> table1Columns : </b> Columns to be selected from table1. <br>
    + * <b> table2Columns : </b> Columns to be selected from table2. <br>
    + * <br>
    + *
    + * @displayName Anti join
    + * @category Stream Manipulators
    + * @tags sql, anti join operator
    + * @since 0.3.3
    + */
    +@OperatorAnnotation(partitionable = false)
    +@Evolving
    +public class AntiJoinOperator implements Operator
    +{
    +
    +  /**
    +   * Join Condition;
    +   */
    +  protected Condition joinCondition;
    +
    +  /**
    +   * Table1 select columns.
    +   * Note: only left table (Table1) will be output in an Anti-join
    +   */
    +  private ArrayList<Index> table1Columns = new ArrayList<Index>();
    +
    +  /**
    +   * Collect data rows from input port 1.
    +   */
    +  protected List<Map<String, Object>> table1;
    --- End diff --
    
    Can we keep this field private? Protected fields are subject to semantic versioning and we should try to keep implementation details encapsulated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---