Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: ilooner <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-80-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-80-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: MLHR-1889 #resolve
 #comment mo...
Content-Type: text/plain
Message-Id: <20151104223846.CFE5BDFF8A@git1-us-west.apache.org>
Date: Wed,  4 Nov 2015 22:38:46 +0000 (UTC)

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/80#discussion_r43951041
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileOutputOperator.java ---
    @@ -642,6 +658,22 @@ protected void closeStream(FSFilterStreamContext streamContext) throws IOExcepti
       }
     
       /**
    +   * Renames source path to destination atomically. This relies on the FileContext api. If
    +   * the underlying filesystem doesn't have an {@link AbstractFileSystem} then this should be overridden.
    +   *
    +   * @param source      source path
    +   * @param destination destination path
    +   * @throws IOException
    +   */
    +  protected void rename(Path source, Path destination) throws IOException
    --- End diff --
    
    Could this method be used to rename files in finalizeFile?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---