apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-273 - Fix existing checksty...
Date Sun, 29 Nov 2015 23:21:04 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/175#discussion_r46100090
  
    --- Diff: bufferserver/src/main/java/com/datatorrent/bufferserver/internal/DataList.java
---
    @@ -139,13 +140,16 @@ public void rewind(final int baseSeconds, final int windowId) throws
IOException
         }
     
         /*
    -      TODO: properly rewind Data List iterators, especially handle case when iterators
point to blocks past the last block.
    -    */
    +     * TODO: properly rewind Data List iterators, especially handle case when iterators
point to blocks past the last
    +     *  block.
    +     */
     
         final int numberOfInMemBlockPermits = this.numberOfInMemBlockPermits.addAndGet(numberOfInMemBlockRewound);
    -    assert numberOfInMemBlockPermits < MAX_COUNT_OF_INMEM_BLOCKS : "Number of in memory
block permits " + numberOfInMemBlockPermits + " exceeded configured maximum " + MAX_COUNT_OF_INMEM_BLOCKS
+ '.';
    +    assert numberOfInMemBlockPermits < MAX_COUNT_OF_INMEM_BLOCKS : "Number of in memory
block permits " +
    +        numberOfInMemBlockPermits + " exceeded configured maximum " + MAX_COUNT_OF_INMEM_BLOCKS
+ '.';
         resumeSuspendedClients(numberOfInMemBlockPermits);
    -    logger.debug("Discarded {} in memory blocks during rewind. Number of in memory blocks
permits {} after rewinding {}. ", numberOfInMemBlockRewound, numberOfInMemBlockPermits, this);
    +    logger.debug("Discarded {} in memory blocks during rewind. Number of in memory blocks
permits {} after" +
    +        " rewinding {}.", numberOfInMemBlockRewound, numberOfInMemBlockPermits, this);
    --- End diff --
    
    This change set illustrates in several cases how readability is affected by the line length
enforcement. Breaking string literals to make checkstyle happy looks just wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message