apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Wed, 25 Nov 2015 07:28:15 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r45835716
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
    @@ -2405,6 +2516,46 @@ private LogicalOperatorInfo fillLogicalOperatorInfo(OperatorMeta
operator)
         return loi;
       }
     
    +  private LogicalModuleInfo fillLogicalModuleInfo(ModuleMeta module, boolean flatten)
    +  {
    +    LogicalModuleInfo lmi = new LogicalModuleInfo();
    +    lmi.name = module.getName();
    +    lmi.className = module.getModule().getClass().getName();
    +    if (flatten) {
    +      for (OperatorMeta operatorMeta : getLogicalPlan().getAllOperators()) {
    +        if (operatorMeta.getModuleName() != null
    +            && (operatorMeta.getModuleName().equals(module.getName()) || operatorMeta.getModuleName().equals(
    +                module.getParentModuleName() + "_" + module.getName()))) {
    +          lmi.operators.add(fillLogicalOperatorInfo(operatorMeta));
    +        }
    +      }
    +      for (StreamMeta streamMeta : getLogicalPlan().getAllStreams()) {
    --- End diff --
    
    Why again do we iterate over all streams when we have already looked at all operators?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message