apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-268 #resolve
Date Tue, 17 Nov 2015 18:42:49 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/171#discussion_r45100607
  
    --- Diff: common/src/main/java/com/datatorrent/common/util/PubSubWebSocketClient.java
---
    @@ -376,7 +385,8 @@ public void unsubscribe(String topic) throws IOException
        * @return subscribe num subscriber message.
        * @throws IOException
        */
    -  public static <T> String constructSubscribeNumSubscribersMessage(String topic,
PubSubMessageCodec<T> codec) throws IOException
    +  public static <T> String constructSubscribeNumSubscribersMessage(String topic,
PubSubMessageCodec<T> codec) throws
    +      IOException
    --- End diff --
    
    The line break here should probably be before the throw keyword


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message