apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-268 #resolve
Date Tue, 17 Nov 2015 15:08:56 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/171#discussion_r45070227
  
    --- Diff: common/src/main/java/com/datatorrent/common/experimental/AppData.java ---
    @@ -60,16 +62,18 @@
       }
     
       /**
    -   * This interface represents a query operator which can be embedded into an AppData
data source. This operator could also
    -   * be used as a standalone operator. The distinction between being used in a standalone
or embedded context is made by
    -   * the {@link EmbeddableQueryInfoProvider#enableEmbeddedMode} method. If this method
is called at least once then the {@link EmbeddableQueryInfoProvider}
    -   * will operate as if it were embedded in an {@link AppData.Store} operator. If this
method is never called then the operator will behave as if
    +   * This interface represents a query operator which can be embedded into an AppData
data source. This operator
    +   * could also be used as a standalone operator. The distinction between being used
in a standalone or embedded
    +   * context is made by the {@link EmbeddableQueryInfoProvider#enableEmbeddedMode} method.
    +   * If this method is called at least once then the {@link EmbeddableQueryInfoProvider}
will operate as if it were
    +   * embedded in an {@link AppData.Store} operator. If this method is never called then
the operator will behave as if
        * it were a standalone operator.<br/><br/>
    -   * <b>Note:</b> When an {@link EmbeddableQueryInfoProvider} is set on an
{@link AppData.Store} then it's {@link EmbeddableQueryInfoProvider#enableEmbeddedMode}
    -   * method is called before {@link Operator#setup}.
    +   * <b>Note:</b> When an {@link EmbeddableQueryInfoProvider} is set on an
{@link AppData.Store} then it's
    +   * {@link EmbeddableQueryInfoProvider#enableEmbeddedMode} method is called before {@link
Operator#setup}.
        * @param <QUERY_TYPE> The type of the query emitted by the operator.
        */
    -  interface EmbeddableQueryInfoProvider<QUERY_TYPE> extends Operator, ConnectionInfoProvider,
Operator.ActivationListener<OperatorContext>
    +  interface EmbeddableQueryInfoProvider<QUERY_TYPE> extends Operator, ConnectionInfoProvider,
Operator
    +      .ActivationListener<OperatorContext>
    --- End diff --
    
    It is more readable to wrap on space, not on dot


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message