apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: Introduce Abstract and Forwardin...
Date Mon, 16 Nov 2015 16:16:31 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/162#discussion_r44943593
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/Reservoir.java ---
    @@ -23,20 +23,26 @@
      *
      * @since 0.3.2
      */
    -public interface Reservoir
    +public interface Reservoir<T>
     {
       /**
        * the count of elements in this SweepableReservoir.
        *
        * @return the count
        */
    -  public int size();
    +  int size(final boolean dataTupleAware);
    --- End diff --
    
    I agree.. I was just giving documentation of the parameter as it was me who has added
this check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message