apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chinmaykolhatkar <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-103: Add module and dag int...
Date Thu, 05 Nov 2015 06:41:44 GMT
Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/148#discussion_r43980659
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -1066,29 +1104,182 @@ public int hashCode()
       @Override
       public <T extends Operator> T addOperator(String name, T operator)
       {
    +    name = moduleStack.empty() ? name : moduleStack.peek().getName() + "_" + name;
         if (operators.containsKey(name)) {
    -      if (operators.get(name) == (Object)operator) {
    +      if (operators.get(name).operator == operator) {
             return operator;
           }
           throw new IllegalArgumentException("duplicate operator id: " + operators.get(name));
         }
     
         OperatorMeta decl = new OperatorMeta(name, operator);
    +    decl.setParentModuleName(moduleStack.empty() ? null : moduleStack.peek().getName());
         rootOperators.add(decl); // will be removed when a sink is added to an input port
for this operator
         operators.put(name, decl);
         return operator;
       }
     
    -  @Override
    -  public <T extends Module> T addModule(String name, Class<T> moduleClass)
    +  public final class ModuleMeta implements DAG.ModuleMeta, Serializable
       {
    -    throw new UnsupportedOperationException("Modules are not supported");
    +    private final LinkedHashMap<InputPortMeta, StreamMeta> inputStreams = new LinkedHashMap<InputPortMeta,
StreamMeta>();
    +    private final LinkedHashMap<OutputPortMeta, StreamMeta> outputStreams = new
LinkedHashMap<OutputPortMeta, StreamMeta>();
    +    private final Attribute.AttributeMap attributes;
    +    @SuppressWarnings("unused")
    +    private final int id;
    +    @NotNull
    +    private final String name;
    +    private transient Integer nindex; // for cycle detection
    +    private transient Integer lowlink; // for cycle detection
    +    private transient Module module;
    +    private String parentModuleName;
    --- End diff --
    
    It is meant to be parent module name only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message