apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: MLHR-1889 #resolve #comment mo...
Date Wed, 04 Nov 2015 23:17:24 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/80#discussion_r43955585
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileOutputOperator.java
---
    @@ -642,6 +658,22 @@ protected void closeStream(FSFilterStreamContext streamContext) throws
IOExcepti
       }
     
       /**
    +   * Renames source path to destination atomically. This relies on the FileContext api.
If
    +   * the underlying filesystem doesn't have an {@link AbstractFileSystem} then this should
be overridden.
    +   *
    +   * @param source      source path
    +   * @param destination destination path
    +   * @throws IOException
    +   */
    +  protected void rename(Path source, Path destination) throws IOException
    --- End diff --
    
    yeah good catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message