Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: "Ganelin, Ilya" <Ilya.Ganelin@capitalone.com>
To: "dev@apex.incubator.apache.org" <dev@apex.incubator.apache.org>
Date: Tue, 20 Oct 2015 11:42:58 -0400
Subject: CodeStyle and CheckStyle Inconsistencies
Thread-Topic: CodeStyle and CheckStyle Inconsistencies
Thread-Index: AdELTfKXunoZ/r2wSMqr+HwtLcGaNA==
Message-ID: <FE0DE244-22E0-4037-8DB8-B53989EAE347@capitalone.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable

All - there are some issues I=92ve already run into with the CodeStyle/Chec=
kStyle settings. I suggest we start a JIRA to track these unless you have a=
 preferred approach.

1) CheckStyle dictates that chained method calls be on different lines but =
also dictates that a space may not precede a period. The below is thus inva=
lid:
    Foo.bar
         .cat
2) Continuation Indent is set to 4 in CheckStyle but set to 2 by default in=
 CodeStyle
3) We should really enforce line limits (for the sake of readability) and s=
hould therefore amend the wrapping behavior of methods. However, this will =
require updating CheckStyle as well. =

4) We should enforce JavaDocs

As an aside, could someone possibly speak to the lineage of the CheckStyle =
and CodeStyle settings that we=92re presently using inside Apex? Did these =
come from published settings (e.g. Google) or are these all in-house?

Appreciate any input, thanks!
________________________________________________________

The information contained in this e-mail is confidential and/or proprietary=
 to Capital One and/or its affiliates and may only be used solely in perfor=
mance of work or services for Capital One. The information transmitted here=
with is intended only for use by the individual or entity to which it is ad=
dressed. If the reader of this message is not the intended recipient, you a=
re hereby notified that any review, retransmission, dissemination, distribu=
tion, copying or other use of, or taking of any action in reliance upon thi=
s information is strictly prohibited. If you have received this communicati=
on in error, please contact the sender and delete the material from your co=
mputer.

________________________________________________________

The information contained in this e-mail is confidential and/or proprietary=
 to Capital One and/or its affiliates and may only be used solely in perfor=
mance of work or services for Capital One. The information transmitted here=
with is intended only for use by the individual or entity to which it is ad=
dressed. If the reader of this message is not the intended recipient, you a=
re hereby notified that any review, retransmission, dissemination, distribu=
tion, copying or other use of, or taking of any action in reliance upon thi=
s information is strictly prohibited. If you have received this communicati=
on in error, please contact the sender and delete the material from your co=
mputer.