Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D01F818BF0 for ; Tue, 20 Oct 2015 18:21:39 +0000 (UTC) Received: (qmail 54893 invoked by uid 500); 20 Oct 2015 18:21:39 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 54836 invoked by uid 500); 20 Oct 2015 18:21:39 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 54825 invoked by uid 99); 20 Oct 2015 18:21:39 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 18:21:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 09358180A4D for ; Tue, 20 Oct 2015 18:21:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.981 X-Spam-Level: ** X-Spam-Status: No, score=2.981 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id FeWPOuKxi4_c for ; Tue, 20 Oct 2015 18:21:32 +0000 (UTC) Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id BF89A211A9 for ; Tue, 20 Oct 2015 18:21:31 +0000 (UTC) Received: by wijp11 with SMTP id p11so60388875wij.0 for ; Tue, 20 Oct 2015 11:21:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=Hk8VXvyKLgus6GeFql5kDcn1Zf6Jnnr1U1+j/kr/RIU=; b=ZA8ri2DC7N6GRosjUBXl9WRo9rpmeW5+XN/U183qrzPOqooSxUzWPdALo0gDrSc/cU zM6iAwavu+9gLj1cpgqH+btdbhg3/DUqRUH4Dq7N8cHuBFBnBv0abqG6twmdbqVHoK7W +IblLuUxx2QQxUoJy7RIaPGVf18JE/HbAnK0Zn+Jc8bWp9uo9S8MjFsZQo7xeTQokVRD SyGIsEbSqGr42GNItEEDpY4cuKu0o6mEMLMczkJj+jDIKICjFdmE19mr9/sSm1aHIhDD 7jJqaE29RUpgI6qEjBC/G0j6e3gmxHrEMy0/keHCD04mTUrLja7MdDwD+0G7uQH1J9ym RWuQ== X-Gm-Message-State: ALoCoQkEXTTcN2Xh2+a7G0V6BLS0UMD4VuCz8/KSsanpdmVCbuItN1A89tneYdZydJPx97Xt+OY+ MIME-Version: 1.0 X-Received: by 10.194.129.129 with SMTP id nw1mr6691128wjb.37.1445365290527; Tue, 20 Oct 2015 11:21:30 -0700 (PDT) Received: by 10.28.220.70 with HTTP; Tue, 20 Oct 2015 11:21:30 -0700 (PDT) In-Reply-To: <562684A9.9080003@datatorrent.com> References: <562684A9.9080003@datatorrent.com> Date: Tue, 20 Oct 2015 11:21:30 -0700 Message-ID: Subject: Re: Existing checkstyle violations From: Chandni Singh To: dev@apex.incubator.apache.org Content-Type: multipart/alternative; boundary=089e01161010b6758a05228d5475 --089e01161010b6758a05228d5475 Content-Type: text/plain; charset=UTF-8 +1 for approach 2 Preserves git annotation. On Tue, Oct 20, 2015 at 11:15 AM, Vlad Rozov wrote: > All, > > We have a large number of existing checkstyle violations and it is > cumbersome to distinguish a newly introduced violation from existing ones. > We need to agree on the process to fix them and there are multiple > approaches how we can do it. > > 1. Fix them all in a single commit (one commit for Core and one for > Malhar). Pros: change can easily be distinguished from logical code > changes. Cons: large number of changes in a single commit, hard to review. > Changes and review likely to be done by developers not familiar with code > specifics. > 2. Fix as we go. Only change code style violation in modified places. > Pros: limited amount of change. Easy to review. Cons: likely to take > forever. Some part of the code may not be fixed at all. > 3. Somewhat combination of 1 & 2. Fix all violations in files affected by > a commit. Pros: changes likely to be done by developers familiar with the > code. Cons: harder to distinguish between logical and style changes in a > single commit. > 4. Any other suggestions? > > Independently of the approach selected, we should not allow commits where > entire file is modified due to style modifications. Such file(s) needs to > be fixed and committed using Malhar CI. > > Thank you, > > Vlad > > --089e01161010b6758a05228d5475--