apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chandni Singh <chan...@datatorrent.com>
Subject Re: Handling wildcard imports
Date Fri, 02 Oct 2015 23:54:38 GMT
Since there aren't any objections I will go ahead and create a jira for
disallowing imports.

On Fri, Oct 2, 2015 at 10:43 AM, Siyuan Hua <siyuan@datatorrent.com> wrote:

> +1 for disabling wildcard imports here IDE can do the work anyways
>
> On Fri, Oct 2, 2015 at 10:39 AM, York, Brennon <
> Brennon.York@capitalone.com>
> wrote:
>
> > +1 for disabling wildcard imports here.
> >
> > On 10/1/15, 11:09 PM, "Chandni Singh" <chandni@datatorrent.com> wrote:
> >
> > >The discussion about wildcards spun off from a previous discussion about
> > >imports. Summarizing the options:
> > >
> > >1. Currently with checkstyle we cannot validate that a wildcard import
> > >was
> > >inserted only if the count is greater than a specified number.
> > >
> > >However in the settings we provide we can specify this number only for
> > >regular imports not static imports.
> > >
> > >I think it should be 10, i.e., if class count is greater than 10 number,
> > >insert a wildcard import.
> > >
> > >Disable wildcard import for static imports.
> > >
> > >Also I think there is a need for documenting our style and rules.
> > >2. The standard checkstyle configurations of sun and google completely
> > >avoid wildcard imports and the rationale is :
> > >
> > >Rationale: Importing all classes from a package or static members from a
> > >class leads to tight coupling between packages or classes and might lead
> > >to
> > >problems when a new version of a library introduces name clashes.
> > >
> > >Most IDEs actually hide imports so even this makes sense as well
> > >
> > >
> > >I am +1 for disabling wildcard imports.
> > >
> > >Please provide your feedback.
> > >
> > >Thanks,
> > >
> > >Chandni
> >
> > ________________________________________________________
> >
> > The information contained in this e-mail is confidential and/or
> > proprietary to Capital One and/or its affiliates and may only be used
> > solely in performance of work or services for Capital One. The
> information
> > transmitted herewith is intended only for use by the individual or entity
> > to which it is addressed. If the reader of this message is not the
> intended
> > recipient, you are hereby notified that any review, retransmission,
> > dissemination, distribution, copying or other use of, or taking of any
> > action in reliance upon this information is strictly prohibited. If you
> > have received this communication in error, please contact the sender and
> > delete the material from your computer.
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message