apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Weise <tho...@datatorrent.com>
Subject Re: [MENTORS] Release candidates
Date Mon, 19 Oct 2015 05:44:46 GMT
Hi Justin,

I made these changes:

https://github.com/apache/incubator-apex-core/pull/123

As for the "apache" prefix for the source release artifact name, the Apache
parent pom has no provision for this today. I filed a JIRA for it:

https://issues.apache.org/jira/browse/MPOM-90

Thanks,
Thomas


On Sun, Oct 18, 2015 at 2:44 AM, Justin Mclean <justinmclean@me.com> wrote:

> Hi,
>
> > Is the following addition to NOTICE acceptable?
>
> Looks fine to me. Always good to give credit to where the code come from.
>
> > The licence.txt file is actually used by the build tools to automatically
> > add the header to new files, so it is still needed.
>
> Again along a minor/non issue. Could it be renamed header.txt to be
> clearer?
>
> Thanks,
> Justin
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message