apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Weise <tho...@datatorrent.com>
Subject Re: [MENTORS] Release candidates
Date Sun, 18 Oct 2015 07:12:36 GMT
Hi Justin,

Thanks for the thorough review.

Is the following addition to NOTICE acceptable:

+++ b/NOTICE
@@ -4,3 +4,6 @@ Copyright (c) 2015 The Apache Software Foundation
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).

+The initial developer of the original code is
+Datatorrent, Inc. (http://www.datatorrent.com)
+Copyright (c) 2012 - 2015. All Rights Reserved.

The licence.txt file is actually used by the build tools to automatically
add the header to new files, so it is still needed.

Thanks,
Thomas


On Wed, Oct 14, 2015 at 6:49 PM, Justin Mclean <justin@classsoftware.com>
wrote:

> Hi,
>
> Had a look, it look goods but noticed a couple of (very) minor things:
>
> It’s generally a good idea to add “apache’ to the release artefact name.
> It’s not required but makes it clear where the software comes from and it’s
> been suggested it may give some extra legal protection by using the Apache
> trademark. (but INAL)
>
> The source release includes this file:
>
> ./engine/src/test/resources/testAppPackage/.dt/appcache/mydtapp-1.0-SNAPSHOT.jar
>
> It's not a jar but probably best not to include it? or the entire .dt
> directory?
>
> A couple of java files missing Apache headers, I gather they are sample
> files but still good add a header so people know they can use them.
>
> ./apex-app-archetype/src/main/resources/archetype-resources/src/main/java/__packageInPathFormat__/Application.java
>
> ./apex-app-archetype/src/main/resources/archetype-resources/src/main/java/__packageInPathFormat__/RandomNumberGenerator.java
>
> ./apex-app-archetype/src/main/resources/archetype-resources/src/test/java/__packageInPathFormat__/ApplicationTest.java
>
> NOTICE should probably include a line about who the original copyright
> owners were, something like:
>
> The Initial Developer of the original code, known as XXXX, is YYYY.
>     Copyright 20?? - 20?? YYYY. All Rights Reserved.
>
> And probably no need for license.txt file as it might cause a little
> confusion as it contents are different from LICENSE.
>
> Thanks,
> Justin
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message