apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [MENTORS] Release candidates
Date Thu, 15 Oct 2015 01:49:37 GMT
Hi,

Had a look, it look goods but noticed a couple of (very) minor things:

It’s generally a good idea to add “apache’ to the release artefact name. It’s not
required but makes it clear where the software comes from and it’s been suggested it may
give some extra legal protection by using the Apache trademark. (but INAL)

The source release includes this file:
./engine/src/test/resources/testAppPackage/.dt/appcache/mydtapp-1.0-SNAPSHOT.jar

It's not a jar but probably best not to include it? or the entire .dt directory?

A couple of java files missing Apache headers, I gather they are sample files but still good
add a header so people know they can use them.
./apex-app-archetype/src/main/resources/archetype-resources/src/main/java/__packageInPathFormat__/Application.java
./apex-app-archetype/src/main/resources/archetype-resources/src/main/java/__packageInPathFormat__/RandomNumberGenerator.java
./apex-app-archetype/src/main/resources/archetype-resources/src/test/java/__packageInPathFormat__/ApplicationTest.java

NOTICE should probably include a line about who the original copyright owners were, something
like:

The Initial Developer of the original code, known as XXXX, is YYYY.
    Copyright 20?? - 20?? YYYY. All Rights Reserved.

And probably no need for license.txt file as it might cause a little confusion as it contents
are different from LICENSE.

Thanks,
Justin


Mime
View raw message