apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilooner <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: [APEX-209] Refactored monolithic...
Date Thu, 29 Oct 2015 22:23:22 GMT
Github user ilooner commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/129#issuecomment-152344821
  
    @ilganeli this can change the author of a commit
    
    git commit --amend --author="User Name <user@abc.com>"
    
    I think there are two options for doing this. You can attribute the entire change to the
original author or you can attribute the original code sections to the original author and
the new functions to you. This could be done by submitting two commits. The first commit will
contain all your changes and something like a // at the end of each line of original code.
The second commit would remove the // at the end of each line of original code and will be
attributed to the original author. The second commit could have a message like "restoring
original author"
    
    I suggest posting this pull request to the dev mailing list to get more feedback about
the readability and cleanliness of the change, since there seem to be some differing opinions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message