apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: - APEX-225 #resolve Adds isConne...
Date Tue, 27 Oct 2015 20:08:27 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/139#discussion_r43178802
  
    --- Diff: api/src/main/java/com/datatorrent/api/DefaultInputPort.java ---
    @@ -55,6 +55,15 @@ public void setConnected(boolean connected)
         this.connected = connected;
       }
     
    +  /**
    +   * Returns True if this port is connected. False otherwise.
    --- End diff --
    
    @ilooner sorry about nitpicking. The return type is a primitive boolean so can you please
change `True` to `true` and `False` to `false`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message