apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilganeli <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-204 #resolve #comment setti...
Date Wed, 21 Oct 2015 23:51:38 GMT
Github user ilganeli commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/125#issuecomment-150056437
  
    Vlad - I am concerned that if all check styles are a single commit it will be overwhelmingly
large. I think one commit per small batch of files is more reasonable.
    
    
    
    Thank you,
    Ilya Ganelin
    
    
    
    -----Original Message-----
    From: Vlad Rozov [notifications@github.com<mailto:notifications@github.com>]
    Sent: Wednesday, October 21, 2015 06:25 PM Eastern Standard Time
    To: apache/incubator-apex-core
    Cc: Ganelin, Ilya
    Subject: Re: [incubator-apex-core] APEX-204 #resolve #comment setting linebreaks to true
for NoWhitespac… (#125)
    
    
    @chandnisingh<https://github.com/chandnisingh> I'd prefer to address all known checkstyle
issues in a single commit.
    
    —
    Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-apex-core/pull/125#issuecomment-150041822>.
    ________________________________________________________
    
    The information contained in this e-mail is confidential and/or proprietary to Capital
One and/or its affiliates and may only be used solely in performance of work or services for
Capital One. The information transmitted herewith is intended only for use by the individual
or entity to which it is addressed. If the reader of this message is not the intended recipient,
you are hereby notified that any review, retransmission, dissemination, distribution, copying
or other use of, or taking of any action in reliance upon this information is strictly prohibited.
If you have received this communication in error, please contact the sender and delete the
material from your computer.
    ________________________________________________________
    
    The information contained in this e-mail is confidential and/or proprietary to Capital
One and/or its affiliates and may only be used solely in performance of work or services for
Capital One. The information transmitted herewith is intended only for use by the individual
or entity to which it is addressed. If the reader of this message is not the intended recipient,
you are hereby notified that any review, retransmission, dissemination, distribution, copying
or other use of, or taking of any action in reliance upon this information is strictly prohibited.
If you have received this communication in error, please contact the sender and delete the
material from your computer.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message