apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilganeli <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-150: Added support of Parti...
Date Sat, 17 Oct 2015 06:49:40 GMT
Github user ilganeli commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/76#discussion_r42306644
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/StreamMapping.java
---
    @@ -222,6 +289,12 @@ private void redoMapping() {
           plan.undeployOpers.addAll(currentUnifiers);
           addSlidingUnifiers();
     
    +      List<PTOutput> unifierSources = this.upstream;
    +      Partitioner<Operator> partitioner = streamMeta.getSource().getUnifierMeta().getAttributes().contains(Context.OperatorContext.PARTITIONER)
?
    --- End diff --
    
    If ```streamMeta.getSource().getUnifierMeta().getAttributes().contains(Context.OperatorContext.PARTITIONER)```
and ```(Partitioner<Operator>)streamMeta.getSource().getUnifierMeta().getValue(Context.OperatorContext.PARTITIONER)```
were extracted to variables this would be easier to read and understand what's going on 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message