apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-186 Enable license header c...
Date Fri, 09 Oct 2015 18:23:09 GMT
Github user vrozov commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/106#issuecomment-146953867
  
    Personally I don't mind few seconds extra time for checkstyle and license check during
main development lifecycle as test consumes most of the time and I don't want to rerun tests
after fixing code style or missing/incorrect license. At the same time, if license and code
style templates are integrated into IDE, those checks are redundant most of the time. Can
we get more attention to https://malhar.atlassian.net/browse/APEX-137 and define workflow
for contributors/committers.
    
    It looks that Travis CI status is ignored (https://travis-ci.org/apache/incubator-apex-malhar/builds).
    
    It will be nice to have something like https://issues.apache.org/jira/browse/HDFS-9181?focusedCommentId=14946362&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14946362.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message