apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-186 Enable license header c...
Date Fri, 09 Oct 2015 01:29:36 GMT
Github user vrozov commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/106#issuecomment-146732278
  
    japicmp and maven license checks do run during verify. checkstyle plugin runs during validate
as well as enforcer. apache-rat does not run at all unless explicitly invoked by "mvn apache-rat:check".
Should apache-rat be enabled for automatic run during verify? I think that we need to have
it enabled, so that committers can execute "mvn clean verify" and not to wary that not all
checks are passed.
    
    Will it be better to fail build due to license or checkstyle violation before tests are
executed as tests take most of the time? If developer/contributor wants to skip license/checkstyle
validation, can they do this using command line parameters/properties/flags?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message