apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PramodSSImmaneni <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEX-181 expose getting of rm we...
Date Tue, 06 Oct 2015 03:27:29 GMT
Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/103#discussion_r41222951
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/security/StramWSFilterInitializer.java
---
    @@ -100,51 +97,20 @@ public String getProxyHostAndPort(Configuration conf)
         Replace with methods from Hadoop when HA support is available
         HttpConfig is not used as it's audience is private as well and it's interface has
changed from Hadoop 2.2 to 2.6
       */
    -  public String getResolvedRMWebAppURLWithoutScheme(Configuration conf, String rmId)
{
    -    boolean sslEnabled = conf.getBoolean(
    -            CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_KEY,
    -            CommonConfigurationKeysPublic.HADOOP_SSL_ENABLED_DEFAULT);
    -    return getResolvedRMWebAppURLWithoutScheme(conf, sslEnabled, (rmId != null) ? "."
+ rmId : "");
    +  public String getResolvedRMWebAppURLWithoutScheme(Configuration conf, String rmId)
    +  {
    +    InetSocketAddress socketAddress = StramClientUtils.getRMWebAddress(conf, rmId);
    +    return socketAddress.getHostString() + ":" + socketAddress.getPort();
       }
     
       /*
         From org.apache.hadoop.yarn.webapp.util.WebAppUtils
         Modified for HA support
       */
    -  public String getResolvedRMWebAppURLWithoutScheme(Configuration conf, boolean sslEnabled,
String rmPrpKey)
    +  public String getResolvedRMWebAppURLWithoutScheme(Configuration conf, boolean sslEnabled,
String rmId)
    --- End diff --
    
    Looks like contract of this method has changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message