Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC3EF1812C for ; Fri, 4 Sep 2015 23:02:13 +0000 (UTC) Received: (qmail 40384 invoked by uid 500); 4 Sep 2015 23:02:13 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 40327 invoked by uid 500); 4 Sep 2015 23:02:13 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 40315 invoked by uid 99); 4 Sep 2015 23:02:13 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2015 23:02:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BE579F18E8 for ; Fri, 4 Sep 2015 23:02:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6si3EiqLMUSX for ; Fri, 4 Sep 2015 23:02:06 +0000 (UTC) Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com [209.85.160.176]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 6F1C021342 for ; Fri, 4 Sep 2015 23:02:06 +0000 (UTC) Received: by ykcf206 with SMTP id f206so35047659ykc.3 for ; Fri, 04 Sep 2015 16:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=JecNolXFeyH16qC3/7+NsLnL5G7Cf8XeFhs6cPuudUk=; b=ApTEmk6b2y6/PEXQzO8bHjf6JGItTd4iWuFfdxo5Z5jrpB2O8fGt10d7ieiYJNewzs em6fYE8/mQVXDOG2u1Hnwo5BPUa2cZ4V9+NkOrwUcAScveSrlU6w3Dx4bdD0j2UeTs8T qLC7Mop6OMEM8hk/c2xPCngxuAVYwde0mYHjU/XHQoXxUGGa+TeyrFZqEfn/u/ruDv70 StQLPuySyfxPU7UeGovTzA0Yq+kaVhDubR+gNdHeJL/hD46r+bDQEk5ZnxZQIcq3moAW GqCZOgA8LweUx+wPu5HUCo9/MVTftxdtLt7ku700+4VxVbKOYapn0iHwQOe0c139Hnm6 djfw== X-Gm-Message-State: ALoCoQnU3R9dWSYAi/3wwpjxAset5/92sOPqHfPHJYmN0aikiIFFyTVfd0WqscoBEu2oK6naV8DX MIME-Version: 1.0 X-Received: by 10.170.139.84 with SMTP id g81mr7059014ykc.38.1441407725547; Fri, 04 Sep 2015 16:02:05 -0700 (PDT) Received: by 10.129.46.141 with HTTP; Fri, 4 Sep 2015 16:02:05 -0700 (PDT) In-Reply-To: <55e8ed76.c8c5440a.bad47.1a6c@mx.google.com> References: <55e8ed76.c8c5440a.bad47.1a6c@mx.google.com> Date: Fri, 4 Sep 2015 16:02:05 -0700 Message-ID: Subject: Re: Stray folders under Malhar/lib From: Chetan Narsude To: dev@apex.incubator.apache.org Content-Type: multipart/alternative; boundary=001a1139c656756d50051ef3e310 --001a1139c656756d50051ef3e310 Content-Type: text/plain; charset=UTF-8 Chandni, How much slower is AsyncFSStorageAgent than the FSStorageAgent? If your really found tests slowing down, it seems like a real issue cause AsyncFSStorageAgent should actually make them faster. It needs to be fixed for the prod use cases as well. For practical purposes FSStorageAgent is superseded by AsyncFSStorageAgent. We do not use it in platform any longer. it should not be used for testing either. The accuracy and coverage of tests supersede their speed. Unfortunately, we will have to keep the FSStorageAgent around until we release 4.0. Regardless, the original problem of stray folders is fixed. Let's close this thread and take over the discussion to another thread relevant p On Thu, Sep 3, 2015 at 6:01 PM, chandni@datatorrent.com < chandni@datatorrent.com> wrote: > Chetan, > > I think you have mis understood my comments. Since I proposed a change in > StramLocalCluster which is in platform it is quite evident that I do not > want the application test developer to be concerned about StorageAgent. > > I dont see a use of async writer in local mode. In fact 2 step writes will > only make the tests slower. > > Chandni > > ----- Reply message ----- > From: "Chetan Narsude" > To: > Subject: Stray folders under Malhar/lib > Date: Thu, Sep 3, 2015 5:13 PM > > The problem is the same as BufferServer (BS) needing to write the temp > files. The BS does not write the temp files in stray locations even though > each invocation of StramLocalCluster triggers BS initialization. It checks > with the context for a temporary location automatically to decide a > temporary file location and uses it. > > The AsyncFSStorageAgent needs to follow the exact same pattern now like > bufferserver to write > to the temp location. So while writing the tests one does not have to > specify special location or the code platform executes does not have to be > different in test mode and in the prod mode. So both Thomas and Ram get > what they want. > > Chandni - the StorageAgent is an abstraction. The test developer should not > care about whether it's doing async or sync. That should be handled by > context and ideally the code that executes in both the cases should be the > same. Practically you will have some differences. Needless to say the fewer > the better. > > -- > Chetan > > > The context decides the behavior of the code. Gaurav is almost done with > the > On Thu, Sep 3, 2015 at 3:51 PM, Munagala Ramanath > wrote: > > > Yes Thomas, when I run my app with *dtcli *I'm seeing all those stray > > directories. > > > > I agree that re-configuring a whole bunch of existing tests is not > > something we want to do. > > > > The key question seems to be: *Can we do something in the platform so > that > > both objectives are achieved*, namely: > > (a) Existing unit tests need no re-configuration. > > (b) Neither running unit tests nor running a user application via dtcli > > leaves random directories lying around. > > > > I don't yet know enough about the platform to answer that question but it > > seems like there should be something > > we can do that is not too onerous. > > > > Ram > > > > On Thu, Sep 3, 2015 at 3:35 PM, Thomas Weise > > wrote: > > > > > Ram, > > > > > > Are you referring to running your app from the dtcli? > > > > > > That's one more item to check to not end up with stray files. There is > > > nothing stopping us from using a different default for that use case. > My > > > take is that we should structure this in a way where by default unit > > tests > > > have minimum things to configure and run as fast as reasonably > possible. > > > > > > Thomas > > > > > > On Thu, Sep 3, 2015 at 3:19 PM, Munagala Ramanath > > > > wrote: > > > > > > > It's not just unit tests. > > > > > > > > An app developer is likely to run a random app in LM to uncover bugs > > > before > > > > hitting the cluster. > > > > The closer the LM setup is to the cluster setup (i.e. running as much > > of > > > > the same code as reasonably possible) > > > > the higher the probability that bugs will be hit in LM. > > > > > > > > Ram > > > > > > > > On Thu, Sep 3, 2015 at 3:13 PM, Chandni Singh < > chandni@datatorrent.com > > > > > > > wrote: > > > > > > > > > Yes Chetan, I am claiming that :-) > > > > > > > > > > I still don't understand the need for having two step checkpointing > > in > > > > > LocalMode by default. > > > > > > > > > > StramLocalCluster should simplify test execution environment as > > pointed > > > > out > > > > > by Thomas. > > > > > Async checkpoint should have its own test cases using > > StramLocalCluster > > > > > that should not break when new features are added to the platform. > > > > > But by default I think StramLocalCluster should use synchronous > > > > > checkpointing. > > > > > > > > > > -Chandni > > > > > > > > > > On Thu, Sep 3, 2015 at 2:43 PM, Chetan Narsude < > > chetan@datatorrent.com > > > > > > > > > wrote: > > > > > > > > > > > Changing the storage agent is one of the ways to address the > > symptoms > > > > of > > > > > > the problem. But it's not treating the problem. > > > > > > > > > > > > In this case - change the basePath to a location under target and > > all > > > > the > > > > > > opinions are moot. And someone is claiming that we should not do > > it. > > > > Not > > > > > > sure why. Or is anyone claiming that anymore? > > > > > > > > > > > > -- > > > > > > Chetan > > > > > > > > > > > > On Thu, Sep 3, 2015 at 1:43 PM, Thomas Weise < > > thomas@datatorrent.com > > > > > > > > > > wrote: > > > > > > > > > > > >> Good point regarding the coverage. These JUnit tests are > supposed > > to > > > > > test > > > > > >> individual components and all the tests collectively should > strive > > > to > > > > > >> achieve high coverage. There are tests in Apex to cover storage > > > > agents, > > > > > >> recovery semantics etc. Components that fall outside of the > test > > > > scope > > > > > >> are > > > > > >> reduced as much as possible through mocks (even though there is > > room > > > > for > > > > > >> improvement). > > > > > >> > > > > > >> The tests in Malhar are for operators and applications, not for > > the > > > > > >> engine. > > > > > >> In those cases where LM is used, the intention is to test the > > > > > application > > > > > >> functionality. It is expected that certain configurations are > > > adjusted > > > > > for > > > > > >> the test and dependencies mocked. > > > > > >> > > > > > >> For the local mode, it should not be an issue to use a different > > > > storage > > > > > >> agent when it simplifies the test execution. Specifically, in > this > > > > case, > > > > > >> we > > > > > >> don't want to go and change many tests to make something work > that > > > > isn't > > > > > >> needed. LM is not "production", it is not using HDFS and there > > are a > > > > > >> number > > > > > >> of other important differences that make it possible to run > within > > > the > > > > > >> IDE. > > > > > >> > > > > > >> Instead, focus should be on those things that help with app > > > coverage. > > > > > For > > > > > >> example, in the past we had seen issues with serialization of > > > > operators > > > > > >> that were not uncovered in LM, until we made the serialization > > part > > > of > > > > > the > > > > > >> execution, even when it was not needed for execution. > > > > > >> > > > > > >> Thomas > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > >> On Thu, Sep 3, 2015 at 11:21 AM, Chetan Narsude < > > > > chetan@datatorrent.com > > > > > > > > > > > >> wrote: > > > > > >> > > > > > >> > I think Ram explained in a little more detail on what I am > > > thinking. > > > > > >> > > > > > > >> > Tests are supposed to provide code coverage. Having > localcluster > > > is > > > > > >> already > > > > > >> > a variable, it's not what runs in production. Having a > different > > > > > storage > > > > > >> > agent is another variable and it misses out on testing the > > > > > asynchronous > > > > > >> > flow. The gap keeps on increasing if we continue to do that. > > > > > AsyncFSSA > > > > > >> is > > > > > >> > our default because it's supposed to do everything that > > > > FSStorageAgent > > > > > >> does > > > > > >> > and some more. So not clear as to why the test which creates > > stray > > > > > >> folders > > > > > >> > is not configuring the storage agent properly instead of > > > completely > > > > > >> > changing it out which brings some other problems in as I just > > > > > explained. > > > > > >> > > > > > > >> > If changing the storage agent is the only way to fix the > problem > > > > with > > > > > >> > reasonable effort, then I would concede. I highly doubt that. > > > > > >> > > > > > > >> > -- > > > > > >> > Chetan > > > > > >> > > > > > > >> > On Thu, Sep 3, 2015 at 11:05 AM, Chandni Singh < > > > > > chandni@datatorrent.com > > > > > >> > > > > > > >> > wrote: > > > > > >> > > > > > > >> > > The local mode was so far using FSStorageAgent which was > used > > in > > > > > >> > > production. > > > > > >> > > In production using Async is needed because hdfs writes are > > slow > > > > but > > > > > >> is > > > > > >> > > that the case with LocalMode? > > > > > >> > > > > > > > >> > > In local mode if we use Async we are creating checkpoints > > under > > > > one > > > > > >> local > > > > > >> > > directory and then copying it to another local directory > which > > > > will > > > > > >> not > > > > > >> > > improve any performance. > > > > > >> > > > > > > > >> > > In my opinion StramLocalCluster use synchronous > checkpointing > > as > > > > > >> default. > > > > > >> > > > > > > > >> > > Chandni > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > On Thu, Sep 3, 2015 at 10:09 AM, Chetan Narsude < > > > > > >> chetan@datatorrent.com> > > > > > >> > > wrote: > > > > > >> > > > > > > > >> > >> That sounds a lot like self contradicting reason; Let's > make > > a > > > > > change > > > > > >> > >> because we don't want to make change. :-) > > > > > >> > >> > > > > > >> > >> The code is in certain state. This certain state is > > consistent > > > > with > > > > > >> how > > > > > >> > >> things run in production. In test environment there is a > > > problem > > > > > that > > > > > >> > stray > > > > > >> > >> files are created. It's a small fix to relocate these files > > > > > >> elsewhere. > > > > > >> > What > > > > > >> > >> I am trying to understand is that is not being done? > > > > > >> > >> > > > > > >> > >> -- > > > > > >> > >> Chetan > > > > > >> > >> > > > > > >> > >> On Thu, Sep 3, 2015 at 9:41 AM, Thomas Weise < > > > > > thomas@datatorrent.com > > > > > >> > > > > > > >> > >> wrote: > > > > > >> > >> > > > > > >> > >>> There is no need to configure anything extra with the > > proposed > > > > > >> change, > > > > > >> > it > > > > > >> > >>> just brings back LM to how it worked before. > > > > > >> > >>> > > > > > >> > >>> There is no point modifying n tests for extra setup with > no > > > > gain. > > > > > >> > >>> > > > > > >> > >>> Thomas > > > > > >> > >>> > > > > > >> > >>> On Thu, Sep 3, 2015 at 9:14 AM, Chetan Narsude < > > > > > >> chetan@datatorrent.com > > > > > >> > > > > > > > >> > >>> wrote: > > > > > >> > >>> > > > > > >> > >>> > Why does it matter that AsyncFSStorageAgent is being > used > > > with > > > > > >> > >>> > LocalCluster? It using the localfs and hence no gain is > > the > > > > > >> > >>> implementation > > > > > >> > >>> > detail that's abstracted out by FileSystem already. > > > > > >> > >>> > > > > > > >> > >>> > If there is a problem of random artifacts left behind > > after > > > > the > > > > > >> test, > > > > > >> > >>> there > > > > > >> > >>> > is a reason and most likely it's misconfiguration of the > > > > > >> > StorageAgent. > > > > > >> > >>> Why > > > > > >> > >>> > wouldn't that be fixed. > > > > > >> > >>> > > > > > > >> > >>> > -- > > > > > >> > >>> > Chetan > > > > > >> > >>> > > > > > > >> > >>> > > > > > > >> > >>> > On Thu, Sep 3, 2015 at 8:59 AM, Amol Kekre < > > > > > amol@datatorrent.com> > > > > > >> > >>> wrote: > > > > > >> > >>> > > > > > > >> > >>> > > Clean up container files left over should be a > > distributed > > > > OS > > > > > >> task. > > > > > >> > >>> Clean > > > > > >> > >>> > > up, back up, archive, ... all is for the OS (aka > YARN). > > We > > > > > must > > > > > >> > >>> assume > > > > > >> > >>> > kill > > > > > >> > >>> > > -9. > > > > > >> > >>> > > > > > > > >> > >>> > > The only thing where the operator comes into play is > > > > > >> "teardown()", > > > > > >> > >>> which > > > > > >> > >>> > is > > > > > >> > >>> > > business logic (not Apex engine) issue. This could be > db > > > > > >> connection > > > > > >> > >>> etc. > > > > > >> > >>> > > > > > > > >> > >>> > > Thks, > > > > > >> > >>> > > Amol > > > > > >> > >>> > > > > > > > >> > >>> > > On Thu, Sep 3, 2015 at 8:52 AM, Thomas Weise < > > > > > >> > thomas@datatorrent.com > > > > > >> > >>> > > > > > > >> > >>> > > wrote: > > > > > >> > >>> > > > > > > > >> > >>> > > > When the container gets killed, we should not assume > > > > > anything > > > > > >> > about > > > > > >> > >>> > > > cleanup. It can be a kill -9. Any related "cleanup" > > > falls > > > > > >> under > > > > > >> > >>> nice to > > > > > >> > >>> > > > have, no guarantees. > > > > > >> > >>> > > > > > > > > >> > >>> > > > On Thu, Sep 3, 2015 at 8:49 AM, Chandni Singh < > > > > > >> > >>> chandni@datatorrent.com > > > > > >> > >>> > > > > > > > >> > >>> > > > wrote: > > > > > >> > >>> > > > > > > > > >> > >>> > > > > I have a question regarding what Gaurav mentioned > > > > > >> > >>> > > > > ---- > > > > > >> > >>> > > > > When container runs in cluster, "." specifies the > > > > > containers > > > > > >> > >>> local > > > > > >> > >>> > path > > > > > >> > >>> > > > on > > > > > >> > >>> > > > > the node where container specific jars and other > > > > resources > > > > > >> > >>> resides. > > > > > >> > >>> > It > > > > > >> > >>> > > > > creates a folder under that which is live as long > as > > > > > >> container > > > > > >> > >>> lives. > > > > > >> > >>> > > So > > > > > >> > >>> > > > > there are no vagrant folders anywhere > > > > > >> > >>> > > > > --- > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > When the container gets killed, do we cleanup the > > > > folders > > > > > >> > >>> created by > > > > > >> > >>> > > > Async > > > > > >> > >>> > > > > under the containers working dir? > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > On Thu, Sep 3, 2015 at 8:42 AM, Thomas Weise < > > > > > >> > >>> thomas@datatorrent.com > > > > > >> > >>> > > > > > > > >> > >>> > > > > wrote: > > > > > >> > >>> > > > > > > > > > >> > >>> > > > >> It makes sense to use the synchronous > checkpointing > > > for > > > > > the > > > > > >> > >>> local > > > > > >> > >>> > > mode. > > > > > >> > >>> > > > >> LM is meant to simplify dependencies and setup. > The > > > > > default > > > > > >> > for > > > > > >> > >>> > > > execution > > > > > >> > >>> > > > >> on YARN remains async. > > > > > >> > >>> > > > >> > > > > > >> > >>> > > > >> Thomas > > > > > >> > >>> > > > >> > > > > > >> > >>> > > > >> > > > > > >> > >>> > > > >> On Thu, Sep 3, 2015 at 8:34 AM, Chandni Singh < > > > > > >> > >>> > > chandni@datatorrent.com> > > > > > >> > >>> > > > >> wrote: > > > > > >> > >>> > > > >> > > > > > >> > >>> > > > >>> APPLICATION_PATH isn't related to local base dir > > of > > > > > Async > > > > > >> as > > > > > >> > >>> far > > > > > >> > >>> > as I > > > > > >> > >>> > > > >>> know. StramLocalCluster sets the APP_PATH to > > > > > "target/...". > > > > > >> > >>> > > > >>> StramLocalCluster should use FSStorageAgent. > > > > > >> > >>> > > > >>> > > > > > >> > >>> > > > >>> - Chandni > > > > > >> > >>> > > > >>> > > > > > >> > >>> > > > >>> On Thu, Sep 3, 2015 at 8:20 AM, Gaurav Gupta < > > > > > >> > >>> > gaurav@datatorrent.com > > > > > >> > >>> > > > > > > > > >> > >>> > > > >>> wrote: > > > > > >> > >>> > > > >>> > > > > > >> > >>> > > > >>>> As Thomas mentioned as default remains to be > > async. > > > > You > > > > > >> can > > > > > >> > >>> either > > > > > >> > >>> > > > >>>> change the storage agent or set the > > > APPLICATION_PATH. > > > > > >> > >>> > > > >>>> > > > > > >> > >>> > > > >>>> When container runs in cluster, "." specifies > the > > > > > >> containers > > > > > >> > >>> local > > > > > >> > >>> > > > path > > > > > >> > >>> > > > >>>> on the node where container specific jars and > > other > > > > > >> > resources > > > > > >> > >>> > > > resides. It > > > > > >> > >>> > > > >>>> creates a folder under that which is live as > long > > > as > > > > > >> > container > > > > > >> > >>> > > lives. > > > > > >> > >>> > > > So > > > > > >> > >>> > > > >>>> there are no vagrant folders anywhere > > > > > >> > >>> > > > >>>> > > > > > >> > >>> > > > >>>> Thanks > > > > > >> > >>> > > > >>>> -Gaurav > > > > > >> > >>> > > > >>>> > > > > > >> > >>> > > > >>>> On Wed, Sep 2, 2015 at 11:33 PM, Chandni Singh > < > > > > > >> > >>> > > > chandni@datatorrent.com > > > > > >> > >>> > > > >>>> > wrote: > > > > > >> > >>> > > > >>>> > > > > > >> > >>> > > > >>>>> I think there is a problem in the default > Async > > as > > > > > >> well. It > > > > > >> > >>> also > > > > > >> > >>> > > uses > > > > > >> > >>> > > > >>>>> the working directory as its local base path. > > > > > >> > >>> > > > >>>>> > > > > > >> > >>> > > > >>>>> In the Async -> copyToHdfs() method, we > delete > > > the > > > > > >> window > > > > > >> > >>> files > > > > > >> > >>> > > but > > > > > >> > >>> > > > >>>>> the folder with the operator name never gets > > > > deleted. > > > > > >> > >>> > > > >>>>> So on the cluster there will be such vagrant > > > > folders > > > > > in > > > > > >> > the > > > > > >> > >>> > > working > > > > > >> > >>> > > > >>>>> directory? > > > > > >> > >>> > > > >>>>> > > > > > >> > >>> > > > >>>>> On Wed, Sep 2, 2015 at 11:17 PM, Thomas Weise > < > > > > > >> > >>> > > > thomas@datatorrent.com> > > > > > >> > >>> > > > >>>>> wrote: > > > > > >> > >>> > > > >>>>> > > > > > >> > >>> > > > >>>>>> Chandni, > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>>> Agreed. See whether the tests work with the > > > > > synchronous > > > > > >> > >>> storage > > > > > >> > >>> > > > >>>>>> agent. If yes, change them. The default needs > > to > > > > > remain > > > > > >> > >>> async. > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>>> Thomas > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>>> On Wed, Sep 2, 2015 at 11:05 PM, Chandni > Singh > > < > > > > > >> > >>> > > > >>>>>> chandni@datatorrent.com> wrote: > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>>>> Hi, > > > > > >> > >>> > > > >>>>>>> > > > > > >> > >>> > > > >>>>>>> I would like to know what was the reason to > > use > > > > > >> > >>> > > AsyncFSStorageAgent > > > > > >> > >>> > > > >>>>>>> with StramLocalCluster? > > > > > >> > >>> > > > >>>>>>> StramLocalCluster is mainly for testing in a > > > > > >> > >>> non-distributed > > > > > >> > >>> > mode > > > > > >> > >>> > > > >>>>>>> and I am unclear how AsyncFSStorageAgent is > > > > helpful > > > > > in > > > > > >> > this > > > > > >> > >>> > mode. > > > > > >> > >>> > > > >>>>>>> > > > > > >> > >>> > > > >>>>>>> Thanks, > > > > > >> > >>> > > > >>>>>>> Chandni > > > > > >> > >>> > > > >>>>>>> > > > > > >> > >>> > > > >>>>>>> On Wed, Sep 2, 2015 at 10:45 PM, Chandni > > Singh < > > > > > >> > >>> > > > >>>>>>> chandni@datatorrent.com> wrote: > > > > > >> > >>> > > > >>>>>>> > > > > > >> > >>> > > > >>>>>>>> This is because of recent changes to > > > > > >> StramLocalCluster > > > > > >> > >>> where > > > > > >> > >>> > > > >>>>>>>> AsyncFSStorageAgent is used for > checkpointing > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> > > dag.setAttribute(OperatorContext.STORAGE_AGENT, > > > > new > > > > > >> > >>> > > > AsyncFSStorageAgent(new Path(pathUri, > > > > > >> > >>> > > > LogicalPlan.SUBDIR_CHECKPOINTS).toString(), null)); > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> The AsyncFSStorageAgent(String path, > > > > Configuration > > > > > >> conf) > > > > > >> > >>> uses > > > > > >> > >>> > > "." > > > > > >> > >>> > > > as localBasePath and therefore creates > sub-directories > > > per > > > > > >> > >>> operator in > > > > > >> > >>> > > the > > > > > >> > >>> > > > current working directory. > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> I am going to create a ticket to address > this > > > and > > > > > >> will > > > > > >> > >>> fix it. > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> -Chandni > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> On Wed, Sep 2, 2015 at 7:13 PM, Chandni > > Singh < > > > > > >> > >>> > > > >>>>>>>> chandni@datatorrent.com> wrote: > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>>> Hi, > > > > > >> > >>> > > > >>>>>>>>> > > > > > >> > >>> > > > >>>>>>>>> I can see empty folders getting created > > under > > > > > >> > Malhar/lib > > > > > >> > >>> > called > > > > > >> > >>> > > > >>>>>>>>> '1' and '2'. > > > > > >> > >>> > > > >>>>>>>>> I think this is because of using LocalMode > > to > > > > run > > > > > a > > > > > >> > test > > > > > >> > >>> > > > >>>>>>>>> application. > > > > > >> > >>> > > > >>>>>>>>> > > > > > >> > >>> > > > >>>>>>>>> > > > > > >> > >>> > > > >>>>>>>>> If anyone has checked in such cases please > > do > > > > > check > > > > > >> and > > > > > >> > >>> let > > > > > >> > >>> > us > > > > > >> > >>> > > > >>>>>>>>> know. > > > > > >> > >>> > > > >>>>>>>>> > > > > > >> > >>> > > > >>>>>>>>> Thanks, > > > > > >> > >>> > > > >>>>>>>>> Chandni > > > > > >> > >>> > > > >>>>>>>>> > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>>> > > > > > >> > >>> > > > >>>>>>> > > > > > >> > >>> > > > >>>>>> > > > > > >> > >>> > > > >>>>> > > > > > >> > >>> > > > >>>> > > > > > >> > >>> > > > >>> > > > > > >> > >>> > > > >> > > > > > >> > >>> > > > > > > > > > >> > >>> > > > > > > > > >> > >>> > > > > > > > >> > >>> > > > > > > >> > >>> > > > > > >> > >> > > > > > >> > >> > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > --001a1139c656756d50051ef3e310--